This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Decouple certificate common name from various components #4759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #4754 |
9a45803 to
8603eea
Compare
Codecov Report
@@ Coverage Diff @@
## main #4759 +/- ##
==========================================
+ Coverage 68.99% 69.06% +0.07%
==========================================
Files 226 225 -1
Lines 16432 16365 -67
==========================================
- Hits 11337 11303 -34
+ Misses 5043 5010 -33
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
keithmattix
reviewed
May 25, 2022
|
I understand what this PR is doing, but couldn't understand how this change helps #4754. Could you describe in the commit message why this decoupling is necessary? |
Good question! That’s definitely not obvious on first pass
|
shashankram
reviewed
May 26, 2022
nojnhuh
reviewed
May 27, 2022
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
shashankram
approved these changes
May 27, 2022
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
nojnhuh
approved these changes
May 27, 2022
jaellio
reviewed
May 27, 2022
jaellio
reviewed
May 27, 2022
04959e1 to
325958b
Compare
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for custom trust domains, I am beginning the process of decoupling the equality between certificate.CommonName, and identity.ServiceIdentity (they will remain tightly coupled, but not strictly equal)
There's a bunch of places in the code that currently relies on CertificateCommonName, particularly with respect to proxies, proxy maps (registries), and xdsLog.
In these cases I prefer using either the UUID, when mapping directly to the proxy OR a new "proxy name" comprised of the uuid and service identity for the xdsLog to maintain the usefulness of having both the identity and uuid.
This PR also removes some dead code as a result of the above changes.