Skip to content

[Bug] Exception when opening this file + stackoverflow when setting parachute to automatic for filled parent #2660

@SiboVG

Description

@SiboVG

Describe the bug

When attempting to open the attached file, I get an error:
image

When assessing the situation better, we found that OR throws a stackoverflow exception when you set the packed diameter/length of a parachute to automatic and its parent is filled.

To Reproduce

For the file error:

  1. Open the file.

For the more general error:

  1. Create a new design
  2. Add a new body tube, set it to Filled
  3. Add a parachute to the body tube, set its packed diameter to Automatic
  4. Stackoverflow

Screenshots / .ork file

.ork file:

corrupted.ork.zip

OpenRocket version

unstable

What platform are you running on?

macOS

Additional context

Additional info from user Aaron on the r/rocketry Discord server who reported the bug:

it looks like the packed length of that parachute is set the Infinity
so I think the only thing I did was click "filled" on the material properties of a tube component
there was an immediate crash error, which I delightfully ignored, and clicked save because I'm not smart
but the thing it seems to be erroring on I don't think is the thing I clicked "filled" for

The packedLength is stored as Infinity:

<subcomponents>
  <parachute>
    <name>Elliptical Parachute [Cd 1.55 (4.5 oz) 21.2 in^3]</name>
    <id>d0edbb07-18d0-4a44-8fc5-226830faca31</id>
    <preset type="PARACHUTE" manufacturer="Fruity Chutes" partno="CFC-036-N" digest="3e4bb4f730fd254365ac7e5f4f0acdf5"/>
    <axialoffset method="middle">0.0</axialoffset>
    <position type="middle">0.0</position>
    <overridemass>0.12757285</overridemass>
    <overridesubcomponentsmass>false</overridesubcomponentsmass>
    <packedlength>Infinity</packedlength>
    <packedradius>auto 0.0</packedradius>
    <radialposition>0.0</radialposition>
    <radialdirection>0.0</radialdirection>
    <cd>1.55</cd>
    <material type="surface" density="0.035653924">Ripstop nylon, lightweight, 3 

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions