-
Notifications
You must be signed in to change notification settings - Fork 89
Add TestMethodsShouldBeVoid
recipe to fix tests not discovered
#791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…return types Fixes #790 Test methods annotated with @test, @ParameterizedTest, @RepeatedTest, etc. should have void return type to ensure proper test discovery in JUnit 5.13+. This recipe: - Changes the return type to void - Removes return statements from the method body - Preserves return statements in nested lambdas and anonymous classes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
src/main/java/org/openrewrite/java/testing/cleanup/TestMethodsShouldBeVoid.java
Outdated
Show resolved
Hide resolved
- Added recipe to JUnit5BestPractices recipe list - Added example demonstrating the recipe transformation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
src/main/java/org/openrewrite/java/testing/cleanup/TestMethodsShouldBeVoid.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/cleanup/TestMethodsShouldBeVoid.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/cleanup/TestMethodsShouldBeVoid.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/cleanup/TestMethodsShouldBeVoid.java
Outdated
Show resolved
Hide resolved
…ShouldBeVoid.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
TestMethodsShouldBeVoid
recipe to fix tests not discovered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Test
,@ParameterizedTest
,@RepeatedTest
, etc.Details
Some test methods with non-void return types were not being discovered or run correctly, causing broken test coverage and warnings in JUnit 5.13+. This recipe automatically fixes test method signatures to ensure proper test discovery and execution.
Changes made:
Created
TestMethodsShouldBeVoid
recipe that:void
Added comprehensive test coverage with 10 test cases covering:
Example transformation:
Test plan
Fixes #790
🤖 Generated with Claude Code