Add JUnitTryFailToAssertThatThrownBy
#781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/org/openrewrite/java/testing/assertj/JUnitTryFailToAssertThatThrownBy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/testing/assertj/JUnitTryFailToAssertThatThrownBy.java
Outdated
Show resolved
Hide resolved
Applied automated reordering of recipe examples from rewriteRun task. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added tests for various scenarios that should NOT be converted: - Nested try-catch blocks (documented current behavior) - Catch blocks with return statements - Exception re-throwing - Exception logging - Exception variable assignment - Try-with-resources - Custom assertions (assertTrue, assertNotNull) - Complex exception handling logic Also added tests for: - Handling of wildcard AssertJ imports - Nested class exceptions (expects fully qualified name) - Comment retention behavior These tests ensure the recipe's conservative approach is maintained and document current behavior for future enhancements. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Applied best practices recipe which reordered the TestMethodsShouldBeVoid example entry in the YAML file for better organization. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.