Skip to content

Conversation

arodionov
Copy link
Contributor

@arodionov arodionov commented May 20, 2025

No description provided.

@arodionov arodionov marked this pull request as ready for review May 21, 2025 22:06
@arodionov
Copy link
Contributor Author

Verified locally on https://github.com/apache/shiro

@arodionov arodionov changed the title [draft] Fix for Assertions.assertDoesNotThrow generator Fix for Assertions.assertDoesNotThrow generator May 22, 2025
@arodionov arodionov requested a review from JohannisK May 22, 2025 10:13
@arodionov arodionov moved this from In Progress to Ready to Review in OpenRewrite May 22, 2025
@arodionov arodionov self-assigned this May 23, 2025
Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see; wherever possible indeed better not to have anything context specific, and since we already use placeholders here and pass in the original LST elements we should be good to remove this.

@timtebeek timtebeek merged commit 0da7676 into main May 26, 2025
2 of 5 checks passed
@timtebeek timtebeek deleted the fix-732 branch May 26, 2025 11:28
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Failure generating Assertions.assertDoesNotThrow in AssertJ migration on Apache Shiro
2 participants