Skip to content

Include additional AssertJ rules/recipes from Error Prone Support #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 1, 2025
Merged

Include additional AssertJ rules/recipes from Error Prone Support #713

merged 15 commits into from
Jun 1, 2025

Conversation

timtebeek
Copy link
Member

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 26, 2025
@timtebeek timtebeek self-assigned this Apr 26, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Apr 26, 2025
@timtebeek timtebeek added recipe Recipe request assertj bug Something isn't working labels Apr 26, 2025
@timtebeek timtebeek mentioned this pull request Apr 26, 2025
Closed
github-actions[bot]

This comment was marked as outdated.

Sign in to view

github-actions[bot]

This comment was marked as outdated.

Sign in to view

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@timtebeek timtebeek marked this pull request as draft May 1, 2025 18:25
github-actions[bot]

This comment was marked as outdated.

Sign in to view

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@timtebeek timtebeek mentioned this pull request May 3, 2025
Merged
@timtebeek
Copy link
Member Author

This PR should help some of the Map cases that now fail to match again:

@timtebeek timtebeek mentioned this pull request May 3, 2025
Merged
@timtebeek timtebeek moved this from Ready to Review to In Progress in OpenRewrite May 4, 2025
github-actions[bot]

This comment was marked as outdated.

Sign in to view

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Jun 1, 2025
@timtebeek timtebeek marked this pull request as ready for review June 1, 2025 21:03
timtebeek
timtebeek commented Jun 1, 2025
View reviewed changes
Copy link
Member Author

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the complete replacement for a lot of declarative recipes that I had hoped for, but still some nice improvements that we can already apply by merging this increment.

@timtebeek timtebeek merged commit 827ba5c into main Jun 1, 2025
2 checks passed
@timtebeek timtebeek deleted the additional-assertj-rules-recipes branch June 1, 2025 21:26
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@timtebeek timtebeek

Labels
assertj bug Something isn't working recipe Recipe request
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimplifyChainedAssertJAssertion should skip Optional values with wildcards
1 participant
@timtebeek