Wrap logging statements with method invocation arguments in an if enabled conditional #215

JohannisK · 2025-04-23T12:18:55Z

What's changed?

Log statements calling methods to build their messages should be enclosed in an is<Level>Enabled() check.

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java

src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggersTest.java

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java

…F4JLoggers.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…F4JLoggersTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…F4JLoggers.java Co-authored-by: Tim te Beek <tim@moderne.io>

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java

src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggersTest.java

…-into-lambdasconditionals

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java

greg-at-moderne

I need to admit the accumulator code is hardly readable for me. But as usual - I fail to have a better suggestion on how to approach this. Maybe we are lacking some utility method/class which would handle that more gracefully.

Having said that, the code LGTM. Good test coverage.

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java

draft

d545e39

JohannisK linked an issue Apr 23, 2025 that may be closed by this pull request

Recipe to put expensive logger parameters into lambdas/conditionals #81

Closed

moderne-meeseeks bot added this to OpenRewrite Apr 23, 2025

github-project-automation bot moved this to In Progress in OpenRewrite Apr 23, 2025

JohannisK added the recipe Recipe Requested label Apr 23, 2025

JohannisK self-assigned this Apr 23, 2025

github-actions bot reviewed Apr 23, 2025

View reviewed changes

timtebeek reviewed Apr 23, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

timtebeek and others added 6 commits April 23, 2025 14:26

Do not call toString on LST element used in JavaTemplate

3f73dda

Update src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSL…

5830e37

…F4JLoggers.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSL…

e3f8c47

…F4JLoggers.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSL…

7ce3af5

…F4JLoggersTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSL…

7bccdb7

…F4JLoggersTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Update src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSL…

ec18c03

…F4JLoggers.java Co-authored-by: Tim te Beek <tim@moderne.io>

timtebeek reviewed Apr 23, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

timtebeek requested changes Apr 23, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

timtebeek reviewed Apr 23, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

Added support for other levels

5f92878

timtebeek marked this pull request as draft April 24, 2025 15:03

timtebeek changed the title ~~WIP: Inexpensive Loggers~~ Wrap logging statements with method invocation arguments in an if enabled conditional Apr 24, 2025

Added after Visitor to bundle log statements

4dbd6db

This comment was marked as off-topic.

Sign in to view

timtebeek reviewed Apr 28, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

timtebeek reviewed Apr 28, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

timtebeek reviewed Apr 28, 2025

View reviewed changes

src/test/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggersTest.java Outdated Show resolved Hide resolved

Renamed executionContext

32059e7

This comment was marked as off-topic.

Sign in to view

JohannisK added 2 commits April 28, 2025 14:36

Fixed bug where unrelated if's were discarded

7d55a8f

Use textblock in CsvSource

7b1127b

This comment was marked as off-topic.

Sign in to view

Keep formatting

108b629

This comment was marked as off-topic.

Sign in to view

Removed star imports

4fc8894

This comment was marked as off-topic.

Sign in to view

JohannisK added 2 commits April 29, 2025 15:43

fixed small issue

a692e10

Merge branch 'main' into 81-recipe-to-put-expensive-logger-parameters…

81b7857

…-into-lambdasconditionals

This comment was marked as off-topic.

Sign in to view

JohannisK marked this pull request as ready for review April 29, 2025 13:58

greg-at-moderne reviewed Apr 29, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

greg-at-moderne approved these changes Apr 29, 2025

View reviewed changes

src/main/java/org/openrewrite/java/logging/slf4j/InexpensiveSLF4JLoggers.java Outdated Show resolved Hide resolved

Minor improvements, added comments to accumulator

e101390

This comment was marked as off-topic.

Sign in to view

JohannisK added 3 commits April 30, 2025 11:26

Added javadoc explaining mechanism in Accumulator

5599a2a

fixed typos

8a035f5

Fixed newline

b633823

This comment was marked as off-topic.

Sign in to view

added braces

135af2d

This comment was marked as off-topic.

Sign in to view

JohannisK merged commit 5d1b4cd into main Apr 30, 2025
2 checks passed

JohannisK deleted the 81-recipe-to-put-expensive-logger-parameters-into-lambdasconditionals branch April 30, 2025 09:55

github-project-automation bot moved this from In Progress to Done in OpenRewrite Apr 30, 2025

timtebeek mentioned this pull request Apr 30, 2025

Add WrapExpensiveLogStatementsInConditionals to Slf4jBestPractices #216

Merged

Wrap logging statements with method invocation arguments in an if enabled conditional #215

Wrap logging statements with method invocation arguments in an if enabled conditional #215

Uh oh!

Conversation

JohannisK commented Apr 23, 2025

What's changed?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

Uh oh!

greg-at-moderne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

Uh oh!

Uh oh!