-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Labels
good first issueGood for newcomersGood for newcomersrecipeRecipe RequestedRecipe Requestedtest provided
Description
What problem are you trying to solve?
Remove .toString()
called on parameterized logging statement arguments.
The logger already calls .toString()
on any non string argument, so there's a potential simplification & performance improvement.
What precondition(s) should be checked before applying this recipe?
Uses logging method and uses toString()
Describe the situation before/after applying the recipe
@Test
void stripToStringFromArguments() {
rewriteRun(
//language=java
java(
"""
import org.slf4j.Logger;
class Test {
static void method(Logger logger, Object person) {
logger.warn("Hello {}", person.toString());
}
}
""",
"""
import org.slf4j.Logger;
class Test {
static void method(Logger logger, Object person) {
logger.warn("Hello {}", person);
}
}
"""
)
);
}
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersrecipeRecipe RequestedRecipe Requestedtest provided
Type
Projects
Status
Done