[v6] Switch to SHA512 as default preferred hash algo (config.preferredHashAlgorithm)
#1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
reviewed
Oct 29, 2024
…hAlgorithm`) SHA512 is usually faster than SHA256 on 64-bit platforms. SHA-512 cannot be used with RSA/DSA keys shorter than 512-bits (which are insecure, but may be used e.g. for testing), so error messages have been improved for this edge case.
1a9a9f7 to
fdab19d
Compare
twiss
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects the preferences of newly generated keys, which by default will have SHA512 as first hash algo preference.
SHA512 will also be used when signing, as long as the signing key declares support for the algorithm.
SHA512 is usually faster than SHA256 (former default) on 64-bit platforms.
NB: SHA512 cannot be used with RSA 512-bit keys (which are insecure, but may be used e.g. for testing), so error messages have been improved for this edge case.