Skip to content

Conversation

larabr
Copy link
Collaborator

@larabr larabr commented Mar 31, 2023

This addition is backwards compatible. We offer no way to generate v4 keys in the new format, since existing implementations might not support them.

TODO:

@larabr larabr changed the title crypto-refresh: add support for Ed488/X448 crypto-refresh: add support for Ed448/X448 Mar 31, 2023
@larabr larabr force-pushed the add-448 branch 2 times, most recently from 9115132 to 23d2d52 Compare April 25, 2023 09:24
@paulmillr
Copy link

What is your policy with regards to browser versions? I notice you support Safari 13. The browser is used by 0.38%+0.77% of users globally, as per caniuse.

v13 was last updated with 13.1.2 on July 15, 2020 - around 3 years ago. Safari 13 has following vulnerabilities:

Also, the bn.js shim has likely not been audited and fuzzed properly.

@larabr
Copy link
Collaborator Author

larabr commented May 17, 2023

Hey @paulmillr , we've confirmed with internal stats that around 1% of our end users are on Safari 13 (desktop or mobile), and that's too large a chunk for us to drop support, considering that BigInt cannot be polyfilled. Hopefully the usage goes down enough in the next year and we can require BigInt in OpenPGP.js v7.

As for bn.js, it's a library that OpenPGP.js has used for a while, both directly and as part of elliptic.js, and while this is certainly no guarantee of security, we are positive about its stability. Unlike previous versions of OpenPGP.js, once we switch to noble-curves, bn.js will only be used as fallback for legacy browsers and the Brainpool curves. Plus, thanks to the design of the BigInteger interface, if we find a better fallback library it'll be easy to switch out bn.js for that.

@paulmillr
Copy link

Understood. Thanks for clarification.

@larabr larabr changed the title crypto-refresh: add support for Ed448/X448 [v6] crypto-refresh: add support for Ed448/X448 Sep 29, 2023
@larabr larabr requested a review from twiss September 29, 2023 14:57
@larabr larabr force-pushed the add-448 branch 2 times, most recently from 795b4ba to bde8d11 Compare October 4, 2023 13:59
@larabr larabr merged commit e9ba20d into openpgpjs:v6 Oct 20, 2023
This was referenced Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants