Skip to content

Support Satisfactory 1.0 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Support Satisfactory 1.0 #21

wants to merge 0 commits into from

Conversation

The-Padi
Copy link
Contributor

Updated the Satisfactory protocol to work with the new Lightweight Query API from the 1.0 Satisfactory update

This was referenced Sep 13, 2024
Closed
Merged
Open
@The-Padi
Copy link
Contributor Author

The-Padi commented Oct 2, 2024

😧 What did I do wrong ?

@BattlefieldDuck
Copy link
Member

😧 What did I do wrong ?

The tests require an update

@The-Padi
Copy link
Contributor Author

The-Padi commented Oct 3, 2024

Do I have to do something or is it on your side ?

@BattlefieldDuck
Copy link
Member

Do I have to do something or is it on your side ?

It is required to update the tests/protocols/test_satisfactory.py

@The-Padi
Copy link
Contributor Author

Do I have to do something or is it on your side ?

It is required to update the tests/protocols/test_satisfactory.py

I'm a little confused, do I also have to be running a Satisfactory server so pass the tests ?

@BattlefieldDuck
Copy link
Member

Do I have to do something or is it on your side ?

It is required to update the tests/protocols/test_satisfactory.py

I'm a little confused, do I also have to be running a Satisfactory server so pass the tests ?

Yes, but it is not a must, the actual problem is https://github.com/opengsq/opengsq-python/actions/runs/10855961933/job/30990888626?pr=21#step:6:239

@The-Padi The-Padi closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The-Padi @BattlefieldDuck