-
Notifications
You must be signed in to change notification settings - Fork 36
chore(deps): bump deps #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughUpdated Go toolchain directives and bumped multiple dependencies in go.mod, including OpenFGA modules, protobuf/GRPC/genproto, CEL stack, backoff, mapstructure, cpuid, Prometheus, OpenTelemetry, and golang.org/x packages. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
go.mod (1)
1-94: Audit dependencies: tidy, prune unused, and scan for vulnerabilities
- Run
go mod tidy -compat=1.24to normalize module metadata and refresh go.sum.- Identify and remove any unused direct requirements, for example:
go list -m -f '{{if not .Indirect}}{{.Path}}@{{.Version}}{{end}}' all- Perform a vulnerability sweep. We recommend installing and using Go’s vulnerability checker:
go install golang.org/x/vuln/cmd/govulncheck@latest govulncheck ./...- Commit any updates to go.mod and go.sum.
Let me know if you’d like a follow-up PR to align the CI Go version, run tidy, and prune unused deps.
🧹 Nitpick comments (2)
go.mod (2)
67-68: Prefer stable tags over pseudo-versions when possible
sagikazarmark/locaferoandsourcegraph/concare on pseudo-versions. If feasible, pin to the nearest stable tag to improve reproducibility. If they’re transient-only, it’s fine.
15-19: Retain github.com/openfga/openfga require; verify version compatibilityConfirmed via
go mod why -m github.com/openfga/openfgathat the CLI module imports it directly in:
github.com/openfga/cli/internal/storetestgithub.com/openfga/openfga/pkg/serverDo not drop the direct require. Instead, please ensure that the following pinned versions work together in the CLI:
- github.com/openfga/api/proto v0.0.0-20250806222926-60b2b183a749
- github.com/openfga/go-sdk v0.7.1
- github.com/openfga/language/pkg/go v0.2.0-beta.2.0.20250812011519-a7cd7602df5d
- github.com/openfga/openfga v1.9.3
Run your full test suite and smoke–test any language or proto-driven commands to confirm compatibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test Release Process
- GitHub Check: Tests
- GitHub Check: Analyze (go)
🔇 Additional comments (5)
go.mod (5)
1-94: Overall: deps bump looks coherent; main blocker is thegodirective formatAside from the
go 1.24.0issue, the upgrades are generally consistent and modernize the stack. Once the directive is fixed and basic verifications pass, this should be good to merge.
62-66: No direct Prometheus imports found—indirect upgrade only
Ran a repository-wide search for “prometheus” outsidevendor/and only saw references ingo.mod/go.sum. There are no direct imports of Prometheus client APIs, so this indirect-only version bump does not require any code changes or deprecation checks.
36-36: No direct backoff/v4 imports found
Thebackoff/v4entries in go.sum are from transitive dependencies. Your go.mod only requires v5, and there are noimport "github.com/cenkalti/backoff/v4"usages in the code. No changes needed.
32-32: No direct imports of CEL packages foundA search across all Go files shows neither
cel.dev/exprnorgithub.com/google/cel-gois imported directly. Both entries in go.mod are indirect transitive dependencies. No changes are needed at this time—if you later add direct CEL usage, pick a single stack to avoid mixing.
75-81: No direct OpenTelemetry usage found; v1.37 bump is safeI searched all Go files for any imports or calls against the upgraded Otel modules (
go.opentelemetry.io/otel/..., SDK metric/trace, provider setup functions) and found none. Since your code doesn’t directly reference tracer/meter providers or metric instruments, the indirect version bump to v1.37.0 requires no changes.
7c1c652 to
8cea6de
Compare
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit