-
Notifications
You must be signed in to change notification settings - Fork 36
Create scorecard.yml #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create scorecard.yml #548
Conversation
Adding scorecard for CLI
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughA new GitHub Actions workflow file, Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/scorecard.yml (1)
20-24
: Add a concurrency group to avoid overlapping runsMultiple pushes in quick succession (e.g., force-pushes) will enqueue many identical Scorecard jobs.
A simpleconcurrency
block keeps only the latest run active and frees CI minutes.analysis: name: Scorecard analysis runs-on: ubuntu-latest + concurrency: + group: scorecard-${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/scorecard.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test Release Process
- GitHub Check: Tests
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/scorecard.yml (1)
24-26
:if:
expression may mis-detect default-branch runs
github.event.repository.default_branch == github.ref_name
works forpush
but not for
branch_protection_rule
(wheregithub.ref_name
is empty) and can be noisy when the default
branch is renamed. A more robust guard is to compare against the full ref:- if: github.event.repository.default_branch == github.ref_name || github.event_name == 'pull_request' + if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch) || github.event_name == 'pull_request'
Added commit hash for codeql action
Adding scorecard for CLI. There's a prebuilt Action for this in the Security → Code scanning tab.
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
main
Summary by CodeRabbit