Skip to content

fix: validate command to exit with non-zero status on errors #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2025
Merged

fix: validate command to exit with non-zero status on errors #485

merged 5 commits into from
Apr 21, 2025

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Apr 12, 2025 •
edited
Loading

Description

This PR fixes the fga model validate command to properly exit with a non-zero status code when validation fails, making it more useful in CI/CD pipelines and build tools like Bazel.

Also fixed some linting issues related to function ordering in the codebase.

References

fixes #484

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@Siddhant-K-code Siddhant-K-code requested a review from a team as a code owner April 12, 2025 17:41
@Siddhant-K-code Siddhant-K-code changed the title Fix: Model validate command exits with code 1 on validation failure Fix validate command to exit with non-zero status on errors Apr 12, 2025
This was referenced Apr 19, 2025
Closed
Closed
@rhamzeh rhamzeh added this pull request to the merge queue Apr 21, 2025
@rhamzeh rhamzeh changed the title Fix validate command to exit with non-zero status on errors fix: validate command to exit with non-zero status on errors Apr 21, 2025
Merged via the queue into openfga:main with commit 7633b14 Apr 21, 2025
16 checks passed
@Siddhant-K-code Siddhant-K-code deleted the fix/484 branch April 21, 2025 15:43
@rhamzeh rhamzeh mentioned this pull request Apr 23, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate does not exit 1 on error
2 participants
@Siddhant-K-code @rhamzeh