Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openfaas/faas-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.17.0
Choose a base ref
...
head repository: openfaas/faas-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.17.1
Choose a head ref
  • 11 commits
  • 62 files changed
  • 1 contributor

Commits on Jan 23, 2025

  1. Pull templates from store when not present

    Implements a user-experience changes:
    
    faas-cli new - when the templates folder is not present the
    language will be looked up in the template store using the
    default URL or an overriden one.
    
    faas-cli publish - when no template folder is available then
    a pull will be carried out if a configuration section is
    present with a template given within in
    
    Filtering - whilst there is no way to avoid pulling all the
    templates wihtin a repository, only the requested/needed ones
    are expanded by commands like faas-cli new.
    
    Tested mainly with existing-unit tests, faas-cli new / publish
    with and without a templates folder.
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    15ae2e3 View commit details
    Browse the repository at this point in the history
  2. Switch out ruby for dockerfile in tests

    The tests relied on ruby being a long term template in the
    templates repository, however we are moving to a model
    with a repository per template, and this template has gone
    to EOL.
    
    The Dockerfile template makes sense as a replacement and is
    still supported.
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    ef9c610 View commit details
    Browse the repository at this point in the history
  3. Make test more accurate by fixing URLs

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    7fdb7f7 View commit details
    Browse the repository at this point in the history
  4. Accept stack.yaml as a default file if present

    Requested by @welteki, if stack.yml is present then it is
    taken to be the default with a --yaml/-f argument being needed.
    
    This change also looks for stack.yaml as a valid alternative
    name.
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    c4e4ff9 View commit details
    Browse the repository at this point in the history
  5. Update CI test to use python3-http instead of EOL template

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    0b5ae5a View commit details
    Browse the repository at this point in the history
  6. Name template from python3 to python3-http

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    6eeded5 View commit details
    Browse the repository at this point in the history
  7. Fail integration test early through set mechanisms

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    d3c89eb View commit details
    Browse the repository at this point in the history
  8. Better error handling and Handle potential permissions issue

    err could be nil, so it is checked before checking for the
    type of error. This may not be needed, but is a better
    default to establish since code is often copied by new
    contributors when adding features.
    
    Addresses comment by @rgee0 for handling error from stat.
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    11885ac View commit details
    Browse the repository at this point in the history
  9. Fix bash test

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 23, 2025
    Configuration menu
    Copy the full SHA
    13a967a View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2025

  1. Update faas-cli new to use stack.yaml

    Updates faas-cli new to create a stack.yaml file instead of
    a YAML file named after the function. This is to help users
    discover that stack.yaml does not require a --yaml or -f
    flag which can become cumbersome.
    
    When a stack.yaml or the file specified via -f already exists
    the new command will now prompt users to use --append
    
    Convert to SHA256 signatures for the invoke command
    
    This is a convenience option for invoking functions along with
    a signature, if a function accepts one. They should all have been
    moved to sha256 now if they were even using it
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    acb912d View commit details
    Browse the repository at this point in the history
  2. Update vendor in Go.mod

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Jan 27, 2025
    Configuration menu
    Copy the full SHA
    1ca7ded View commit details
    Browse the repository at this point in the history
Loading