Skip to content

Populate disk info for encrypted pools #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2025
Merged

Populate disk info for encrypted pools #1836

merged 2 commits into from
Mar 17, 2025

Conversation

dsharma-dc
Copy link
Contributor

The DISKS field is now populated for an encrypted pool also.

./io-engine-client pool list 
NAME   UUID                                 STATE  CAPACITY   USED USED% CLUSTER_SIZE PAGE_SIZE MD_PAGE_SIZE MD_PAGES MD_USED_PAGES MD_USED% DISKS                                                      DISK_CAPACITY ENCRYPTED
pool-2 f74d6a27-0ed6-4331-9760-29ab2fd76193 online 310378496  0    0.00% 4194304      4096      4096         75       1             1.33%    aio:///dev/loop1?uuid=9cc90df3-828d-4b4a-a357-424f31332604 314572800     false    
pool-1 49c29a9f-bc2e-4c7d-9fd5-12972899c4ec online 5360320512 0    0.00% 4194304      4096      4096         1280     1             0.08%    aio:///dev/loop0?uuid=7870a4dc-fb82-4a57-b3e5-a32b37782fbc 5368709120    true

@dsharma-dc
chore(encryption): get disks list correctly for crypto vbdev
0c11478 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc dsharma-dc requested a review from a team as a code owner March 17, 2025 07:33
@dsharma-dc dsharma-dc changed the title Disk info Populate disk info for encrypted pools Mar 17, 2025
tiagolobocastro
tiagolobocastro approved these changes Mar 17, 2025
View reviewed changes
@dsharma-dc
chore(cli): show encryption status in output
8d1ddbf 
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
@dsharma-dc
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 2e48471 into develop Mar 17, 2025
4 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the disk-info branch March 17, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsharma-dc @tiagolobocastro @Abhinandan-Purkait