Skip to content

vendor: update github.com/cyphar/filepath-securejoin to v0.3.3 #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2024
Merged

vendor: update github.com/cyphar/filepath-securejoin to v0.3.3 #4421

merged 1 commit into from
Oct 1, 2024

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Sep 30, 2024

This fixes issues we had with spurious MkdirAll failures.

Fixes #4408
Signed-off-by: Aleksa Sarai cyphar@cyphar.com

@cyphar
vendor: update github.com/cyphar/filepath-securejoin to v0.3.3
b096459 
This fixes issues we had with spurious MkdirAll failures.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
rata
rata approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! And thanks for having a changelog for this dep, it helps too :)

I guess you verified if this fixes the issue, right?

@cyphar
Copy link
Member Author

cyphar commented Sep 30, 2024

I verified that uid=1234,gid=5678,umask=0 (which is the most extreme example of this problem) doesn't cause errors when using MkdirAll directly.

lifubang
lifubang approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@lifubang lifubang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If there are some test cases for this issue and for "is the created directory empty" logic check, it will be more better, but I think we can add these tests in a new PR. Thanks.

@lifubang lifubang merged commit c611a21 into opencontainers:main Oct 1, 2024
42 checks passed
@cyphar cyphar deleted the filepath-securejoin-0.3.3 branch October 1, 2024 10:07
@github-actions github-actions bot mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rata rata rata approved these changes

@lifubang lifubang lifubang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mkdirall regression when default ACL is set
3 participants
@cyphar @rata @lifubang