Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opencontainers/runc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.9
Choose a base ref
...
head repository: opencontainers/runc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.10
Choose a head ref
  • 17 commits
  • 19 files changed
  • 7 contributors

Commits on Aug 10, 2023

  1. VERSION: back to development

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    11737f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. merge #3981 into opencontainers/runc:release-1.1

    Kir Kolyshkin (2):
      VERSION: back to development
      VERSION: release 1.1.9
    
    LGTMs: mrunalp AkihiroSuda lifubang cyphar
    Closes #3981
    cyphar committed Aug 11, 2023
    1 Configuration menu
    Copy the full SHA
    26a98ea View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Handle kmem.limit_in_bytes removal

    kmem.limit_in_bytes has been removed in upstream linux and this patch
    is queued to be backported to linux 6.1 stable:
    
    - https://lore.kernel.org/linux-mm/20230705134434.GA156754@cmpxchg.org/T/
    - https://www.spinics.net/lists/stable-commits/msg316619.html
    
    Without this change to libcontainerd, GetStats() will return an error
    on the latest kernel(s). A downstream effect is that Kubernetes's
    kubelet does not start up. This fix was tested by ensuring that it
    unblocks kubelet startup when running on the latest kernel.
    
    Signed-off-by: Jordan Rife <jrife0@gmail.com>
    (cherry picked from commit 99469eb)
    Signed-off-by: Jordan Rife <jrife0@gmail.com>
    jrife committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    016b2b4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4028 from jrife/release-1.1

    [1.1 backport] Handle kmem.limit_in_bytes removal
    kolyshkin authored Sep 26, 2023
    1 Configuration menu
    Copy the full SHA
    3854703 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. fix two typos

    Signed-off-by: lifubang <lifubang@acmcoder.com>
    (cherry picked from commit 109dcad)
    Signed-off-by: lifubang <lifubang@acmcoder.com>
    lifubang committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    8f66c9f View commit details
    Browse the repository at this point in the history
  2. fix a typo in cloned_binary.c: re-use -> reuse

    Signed-off-by: lifubang <lifubang@acmcoder.com>
    lifubang committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    b365458 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4055 from lifubang/fix-Typos

    [1.1 backport] fix typos
    AkihiroSuda authored Oct 4, 2023
    1 Configuration menu
    Copy the full SHA
    ad9c301 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Fix directory perms vs umask for tmpcopyup

    Bump fileutils to v0.5.1, which fixes permissions of newly created directories
    to not depend on the value of umask.
    
    Add a test case which fails like this before the fix:
    
    	mounts.bats
    	 ✗ runc run [tmpcopyup]
    	   (in test file tests/integration/mounts.bats, line 28)
    	     `[[ "${lines[0]}" == *'drwxrwxrwx'* ]]' failed
    	   runc spec (status=0):
    
    	   runc run test_busybox (status=0):
    	   drwxr-xr-x    2 root     root            40 Oct  4 22:35 /dir1/dir2
    
    Fixes 3991.
    
    (cherry picked from commit 730bc84)
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5a5b2cc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Merge pull request #4060 from kolyshkin/1.1-4056

    [1.1] Fix directory perms vs umask for tmpcopyup
    mrunalp authored Oct 6, 2023
    1 Configuration menu
    Copy the full SHA
    42acc58 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. ci/gha: fix downloading Release.key

    Since today, the URL from download.opensuse.org started returning a
    HTTP 302 redirect, so -L option for curl is needed to follow it.
    
    While at it, remove apt-key as per its man page recommendation:
    
    > Note: Instead of using this command a keyring should be placed
    > directly in the /etc/apt/trusted.gpg.d/ directory with a descriptive
    > name and either "gpg" or "asc" as file extension.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    (cherry picked from commit f944d7b)
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1f66027 View commit details
    Browse the repository at this point in the history
  2. merge #4081 into opencontainers/runc:release-1.1

    Kir Kolyshkin (1):
      ci/gha: fix downloading Release.key
    
    LGTMs: lifubang cyphar
    cyphar committed Oct 20, 2023
    1 Configuration menu
    Copy the full SHA
    5ba0e01 View commit details
    Browse the repository at this point in the history
  3. [1.1] tests/int/helpers: add get_cgroup_path

    Separate it out of get_cgroup_value. Needed for the next commit.
    
    This function was initially introduced in main branch commit d4582ae.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f8be700 View commit details
    Browse the repository at this point in the history
  4. libct/cg: support hugetlb rsvd

    This adds support for hugetlb.<pagesize>.rsvd limiting and accounting.
    
    The previous non-rsvd max/limit_in_bytes does not account for reserved
    huge page memory, making it possible for a processes to reserve all the
    huge page memory, without being able to allocate it (due to cgroup
    restrictions).
    
    In practice this makes it possible to successfully mmap more huge page
    memory than allowed via the cgroup settings, but when using the memory
    the process will get a SIGBUS and crash. This is bad for applications
    trying to mmap at startup (and it succeeds), but the program crashes
    when starting to use the memory. eg. postgres is doing this by default.
    
    This also keeps writing to the old max/limit_in_bytes, for backward
    compatibility.
    
    More info can be found here: https://lkml.org/lkml/2020/2/3/1153
    
    (commit message mostly written by Odin Ugedal)
    
    [1.1 backport: check for CGROUP_UNIFIED in integration test]
    
    Co-authored-by: Odin Ugedal <odin@ugedal.com>
    (cherry picked from commit 4a7d3ae)
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin and odinuge committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8214e63 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge pull request #4077 from kolyshkin/1.1-4073

    [1.1] libct/cg: support hugetlb rsvd
    AkihiroSuda authored Oct 24, 2023
    1 Configuration menu
    Copy the full SHA
    e1adc7f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. libct/cgroups.OpenFile: clean "file" argument

    This prevents potential exploit of using "../" in cgroups.OpenFile
    (as well as other methods that use OpenFile) to read or write to
    other cgroups.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    (cherry picked from commit 2c9598c)
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b426e9b View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge pull request from GHSA-5g49-rx9x-qfc6

    [1.1] libct/cgroups.OpenFile: clean "file" argument
    cyphar authored Oct 30, 2023
    1 Configuration menu
    Copy the full SHA
    7b469c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. VERSION: release 1.1.10

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    kolyshkin authored and cyphar committed Nov 1, 2023
    1 Configuration menu
    Copy the full SHA
    18a0cb0 View commit details
    Browse the repository at this point in the history
Loading