Skip to content

Test older versions of Go with toolchain=local #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Test older versions of Go with toolchain=local #1133

merged 1 commit into from
Nov 10, 2023

Conversation

sudo-bmitch
Copy link
Contributor

This prevents Go from doing an automatic upgrade, giving a better test of backwards compatibility. Related to #1114 (review)

@sudo-bmitch
Test older versions of Go with toolchain=local
dd66b54 
Signed-off-by: Brandon Mitchell <git@bmitch.net>
@sudo-bmitch sudo-bmitch mentioned this pull request Sep 28, 2023
Merged
thaJeztah
thaJeztah approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neersighted
neersighted approved these changes Nov 2, 2023
View reviewed changes
Copy link

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on experiences in other projects

@sajayantony sajayantony merged commit 90f826d into opencontainers:main Nov 10, 2023
@sudo-bmitch sudo-bmitch deleted the pr-gotoolchain branch November 10, 2023 19:22
@sudo-bmitch sudo-bmitch mentioned this pull request Jan 11, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@sajayantony sajayantony sajayantony approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr is a code owner

@jonboulle jonboulle Awaiting requested review from jonboulle

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

@vbatts vbatts Awaiting requested review from vbatts

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

+2 more reviewers

@neersighted neersighted neersighted approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sudo-bmitch @tianon @neersighted @thaJeztah @sajayantony