Skip to content

Be more strict when parsing charges in SMILES #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Be more strict when parsing charges in SMILES #2132

merged 1 commit into from
Apr 3, 2020

Conversation

baoilleach
Copy link
Member

Previously the following were parsed (copied and pasted from the tests) - now they are rejected as invalid:

                "[CH2++2]",
                "[C+-+-]",
                "[C+2+]"
                "[CH2--2]",
                "[C-+-+]",
                "[C-2-]"

@ghutchis ghutchis merged commit d2fedbb into openbabel:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baoilleach @ghutchis