Skip to content

Bring back support for lowercase elements and D/T in GetAtomicNum(). #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2019
Merged

Bring back support for lowercase elements and D/T in GetAtomicNum(). #2100

merged 3 commits into from
Nov 28, 2019

Conversation

baoilleach
Copy link
Member

Fixes #2063....I believe. Let me test this directly before this is merged.

@baoilleach
Copy link
Member Author

Good to go.

@ghutchis
Copy link
Member

I'm lazy, so I would have just applied a lowercase transform - kudos for making the explicit version of the switch statements.

@ghutchis ghutchis merged commit aa951cb into openbabel:master Nov 28, 2019
@baoilleach baoilleach deleted the lowercase_elements branch November 28, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tmol to inchikey conversion fails in commandline Open Babel 3.0.0
2 participants
@baoilleach @ghutchis