Define OpenBabel3_LIBRARY #2086
Conversation
Every cmake package I've used exports the location of the library as a variable. Perhaps this is no longer considered best practice(?) but it is certainly common and expected practice. This addes an OpenBabel3_LIBRARY variable to the cmake config file which is defined to be $<TARGET_FILE:openbabel> I could not figure out how to get the location of the library relative OpenBabel3_INSTALL_PREFIX
|
Seems like an oversight. Pinging @cryos to see whether he agrees. |
|
Yes I think this is expected behavior too, we normally use the convention of plural for external variables, i.e. the library might be defined in OpenBabel3_LIBRARY, but the variable for the public interface would be OpenBabel3_LIBARIES which may have more things added in the future. Same with _INCLUDE_DIR being internal often, and INCLUDE_DIRS being external - may be the same, but the plural normally defines the interface to use from the outside. |
Also removed python.i change
|
Example usage If I was less intimidated by cmake, I would also attempt to implement concurrent building of python2 and python3 bindings... |
|
IMHO, I think it's time to drop Python2: |
|
I should be able to get the maeparser bit tomorrow. |
I am in favor of making python3 the default (although concurrent builds of 2 and 3 is probably the most user friendly). |
|
Merging. Let's talk about Python elsewhere if need be. |
Every cmake package I've used exports the location of the library as a
variable. Perhaps this is no longer considered best practice(?) but it
is certainly common and expected practice.
This addes an OpenBabel3_LIBRARY variable to the cmake config file which
is defined to be the generator expression $<TARGET_FILE:openbabel>
I could not figure out how to get the location of the library relative
OpenBabel3_INSTALL_PREFIX