This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Add DataCenterLookupValues setting #857
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #856
This PR provides a patch to add a new configuration setting:
DataCenterLookupValues
which would be applied after applyingDataCenterPattern
on the instance hostname.gofmt
(please avoidgoimports
)./build.sh
# this currently fails as you only support up to go 1.10. I'm using go 1.12.go test ./go/...
Please let me know if this looks reasonable.