-
Notifications
You must be signed in to change notification settings - Fork 939
Format delays in days / hours / minutes / seconds #1184
Format delays in days / hours / minutes / seconds #1184
Conversation
cc: @luisyonaldo @dveeden |
Did you insert spaces between units intentionally, i.e. |
Wouldn't there be some JS function that does what Otherwise: Useful functionality and code looks good to me, but didn't test it. side note: You know that instead of editing screenshots you can get orchestrator to mask hostnames? |
I've searched and couldn't find anything that's obviously better. |
I believe JavaScript has nothing to offer. But we should use
golang's existing formatting.
…On Thu, Jun 4, 2020 at 7:20 PM Daniël van Eeden ***@***.***> wrote:
Wouldn't there be some JS function that does what formattedInterval()
does?
I've searched and couldn't find anything that's obviously better.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAT4WPU62IFILRTQ3AVOM6TRU7CT7ANCNFSM4NSYLZ6Q>
.
|
Then we should use only hours, minutes, and seconds. And maybe rename |
To answer the questions:
|
The current implementation already looks good to me 👌 |
Delays are shown in seconds which is fine but often you want to see this in days / hours / minutes and seconds without doing mental arithmetic to figure out the delay.
This patch shows time since a box has been seen and replication delay in days / hours / minutes and seconds and thus saves time with a large delay in seeing what it represents.
I'll include a couple of examples with the new formatting.



I'm exposing lots of warts :-)