Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

Replica with extra_port shows up twice in Orchestrator #923

@dougfales

Description

@dougfales

We use gh-ost on some of our replicas using the extra_port option, which means we often have the same replica showing up twice in Orchestrator's topology graph like so:

ghost_extra_port_duplicate_instance

It would be nice to be able to prevent discovery of nodes on this extra_port, so that once they are forgotten, they stay forgotten (and undiscoverable) forever.

The DiscoveryIgnoreReplicaHostnameFilters might work for us if this instance had a different hostname, but it only differs in port, and we do want it to appear in Orchestrator, just only under its standard port.

Assuming I'm not missing a config option that already does this, I'd like to add support for a DiscoveryIgnorePortFilter setting similar to the DiscoveryIgnoreReplicaHostnameFilters setting.

Alternatively, we could extend the DiscoveryIgnoreReplicaHostnameFilters setting to match against the full StringCode() (hostname:port) so that I could use a setting like:

  "DiscoveryIgnoreReplicaHostnameFilters": ["node1:16022"]

But that would change existing behavior for this setting, which is why I was leaning toward a separate setting for ignoring ports. (Related: I see there is already some work being done on updating the DiscoveryIgnoreReplicaHostnameFilters setting. Maybe I will propose this there as well.)

My question: would you consider a PR that supports this port-ignoring behavior? If so, would you prefer a separate a setting or extending the behavior of DiscoveryIgnoreReplicaHostnameFilters?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions