[WIP] Typing fixes #2939
Merged
[WIP] Typing fixes #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pseudo-rnd-thoughts @jkterry1 I was originally planning to keep this as a relatively long WIP where I go through each file, but it might actually be important to get this merged pretty soon, particularly the narrowing-down of the excludes. The star excludes are a pretty big issue, since they stop type checking from happening to new code as well, which means we continue to produce iffy code. |
…ver reason. It's still exported for backwards compatibility, but internal code now uses a public variable.
|
Agreed, I can help with a separate PR on a separate part of the project if that speeds things up |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Progressively removing excludes from pyright and making them pass.
For now it's only toy_text envs, and I narrowed down the
spacesexclude to the only one that was failing (the new graph space).I'm also planning to narrow down the exclusion lists, since the
Graphspace should have never been merged with failing type checks, but it was just blanket excluded.Fixes # (issue)
Type of change
Please delete options that are not relevant.