Updates the environment checker #2864
Conversation
…pendency groups and collects the requirements from requirements.txt to keep everything standardized.
…assive_env_checker.py with a new wrapper env_checker.py
# Conflicts: # setup.py
…only run on the first environment created.
| ) | ||
|
|
||
|
|
||
| class PassiveEnvChecker(gym.Wrapper): |
There was a problem hiding this comment.
Why define the Wrapper here and the method implementation in another file?
There was a problem hiding this comment.
Good question, I think that is because the passive environment checker file has more functions than are used in the wrapper and I use the passive env reset and step check in the full invasive environment checker. So these functions would have to be in a separate place
| for mode in render_modes: | ||
| env.render(mode=mode) |
There was a problem hiding this comment.
This will not work anymore with the new Render API.
Initially, I thought to just change the env_checker to receive the environment specification. In this way, internally it can creates as many copies as it needs without touching the copy made for the user. Having the env_spec here will also solve the problem for rendering (and in general for checking the parameters that are passed to__init__)
There was a problem hiding this comment.
I don't totally get what you mean, but as this PR is going to be in the next sub-release, would you be able to make the changes in your render PR?
We are still interested in an environment checker being run on
gym.makehowever runningenv_checkeras previously implemented resulted instepandresestbeing called.However, this was found to cause a significant number of issue
Therefore, this PR makes the following upgrades
step,resetandrenderto check that the environments follow the gym API specificationsteporresetfunctions but checks the returns data is correct. In addition, passive observation and action space checkers are added and run on initialisation.gym.make(otherwisedisable_env_checker=Trueis passed. This check will run on only the firstreset,stepandrenderfunction checking their function signatures, and that data returned. As this wrapper needs direct access to the environment, is it the first wrapper applied to the environment ingym.make.