Skip to content

Rename render modes/fps #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Feb 28, 2022
Merged

Rename render modes/fps #2654

merged 28 commits into from
Feb 28, 2022

Conversation

trigaten
Copy link
Contributor

No description provided.

@jkterry1 jkterry1 merged commit 35b78ac into openai:master Feb 28, 2022
@ZhiqingXiao
Copy link
Contributor

@trigaten @jkterry1 Renaming "render.modes" to "render_modes" is unnecessary, and it will introduce incompatibility to many extension libraries.

@pzhokhov
Copy link
Collaborator

pzhokhov commented Mar 7, 2022

@trigaten what is the reason for this change?

@jkterry1
Copy link
Collaborator

jkterry1 commented Mar 7, 2022

@pzhokhov the variable names here are going to become main features of the gym API in the next release instead of being minor features as part of the roadmap to the 1.0 release, so we changed them to a more standardized naming in advance of making them a core feature.

@pseudo-rnd-thoughts
Copy link
Contributor

Running the pytests I get the following warnings, could you fix these

tests/wrappers/test_record_video.py: 10 warnings
tests/wrappers/test_video_recorder.py: 3 warnings
  /gym/wrappers/monitoring/video_recorder.py:115: DeprecationWarning: WARN: `env.metadata["video.frames_per_second"] is marked as deprecated and will be replaced with `env.metadata["render_fps"]` see https://github.com/openai/gym/pull/2654 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants