If config did not end in newline, last line was ignored #602

fsundermeyer · 2021-03-22T17:31:22Z

When read reaches end-of-file instead of end-of-line, it does read in the
data and assign it to the variables, but it exits with a non-zero status.
Fixed this by passing the file via grep ""
Fixes #553

When read reaches end-of-file instead of end-of-line, it does read in the data and assign it to the variables, but it exits with a non-zero status. Fixed this by passing the file via grep "" Fixes #553

ghost

This fixes the issue for me, thanks!

The only issue I see is a small stylistic one: Using grep to add a newline is a bit non-obvious. Imo, something like this would be uglier but more obvious: echo -e "$(cat $CFG)"

If config did not end in newline, last line was ignored

a64d865

When read reaches end-of-file instead of end-of-line, it does read in the data and assign it to the variables, but it exits with a non-zero status. Fixed this by passing the file via grep "" Fixes #553

fsundermeyer requested a review from a user March 22, 2021 17:31

ghost approved these changes Mar 26, 2021

View reviewed changes

fsundermeyer merged commit 07d3e87 into main Mar 26, 2021

ghost deleted the fix_ignore_nonewline_in_config branch April 6, 2021 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

If config did not end in newline, last line was ignored #602

If config did not end in newline, last line was ignored #602

Uh oh!

fsundermeyer commented Mar 22, 2021

Uh oh!

ghost left a comment •

edited by ghost

Loading

Uh oh!

Uh oh!

If config did not end in newline, last line was ignored #602

If config did not end in newline, last line was ignored #602

Uh oh!

Conversation

fsundermeyer commented Mar 22, 2021

Uh oh!

ghost left a comment • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost left a comment •

edited by ghost

Loading