Skip to content

chore: add detailed description for BatchSize #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2024
Merged

chore: add detailed description for BatchSize #113

merged 1 commit into from
Jul 28, 2024

Conversation

xuthus5
Copy link
Member

@xuthus5 xuthus5 commented Jul 17, 2024

fix: #112

@hezhangjian
Copy link
Member

Can we add it to design doc first?

hezhangjian
hezhangjian requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@hezhangjian hezhangjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should establish a mechanism to synchronize method descriptions, as they contain language-independent content.

@xuthus5
chore: add detailed description for BatchSize
abda900 
Signed-off-by: Young Xu <xuthus5@gmail.com>
@hezhangjian hezhangjian merged commit a8b94a3 into openGemini:main Jul 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hezhangjian hezhangjian hezhangjian approved these changes

@Chenxulin97 Chenxulin97 Chenxulin97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

需要检查BatchConfig.BatchSize 的上限值 避免创建管道造成内存溢出 fatal error
3 participants
@xuthus5 @hezhangjian @Chenxulin97