Skip to content

zprop: fix value help for ZPOOL_PROP_CAPACITY #16881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2024
Merged

zprop: fix value help for ZPOOL_PROP_CAPACITY #16881

merged 1 commit into from
Dec 18, 2024

Conversation

robn
Copy link
Member

@robn robn commented Dec 18, 2024

Motivation and Context

Small doc bug. #16876.

Description

Change the value description string.

How Has This Been Tested?

Eyeball:

$ ./zpool get 2>&1 | grep capacity
	capacity               NO   <percent>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn
zprop: fix value help for ZPOOL_PROP_CAPACITY
b1a67ae 
It's a percentage and documented as such, but we were showing it as
<size>.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 18, 2024
@robn robn mentioned this pull request Dec 18, 2024
Open
@behlendorf behlendorf merged commit ab7cbbe into openzfs:master Dec 18, 2024
24 of 26 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 29, 2024
@robn @behlendorf
zprop: fix value help for ZPOOL_PROP_CAPACITY
e90124a 
It's a percentage and documented as such, but we were showing it as
<size>.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#16881
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Jan 26, 2025
@robn @lundman
zprop: fix value help for ZPOOL_PROP_CAPACITY
2aa7592 
It's a percentage and documented as such, but we were showing it as
<size>.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#16881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

+1 more reviewer

@gmelikov gmelikov gmelikov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robn @behlendorf @gmelikov @amotin