Skip to content

【Hackathon 5th No.97】add paddle tanh_shrink op #20067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 12, 2023
Merged

【Hackathon 5th No.97】add paddle tanh_shrink op #20067

merged 18 commits into from
Dec 12, 2023

Conversation

Asthestarsfalll
Copy link
Contributor

@Asthestarsfalll Asthestarsfalll commented Sep 27, 2023 •
edited
Loading

@Asthestarsfalll Asthestarsfalll requested a review from a team as a code owner September 27, 2023 02:36
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: PDPD FE OpenVINO PaddlePaddle FrontEnd labels Sep 27, 2023
@github-actions github-actions bot removed the category: build OpenVINO cmake script / infra label Sep 27, 2023
@Asthestarsfalll Asthestarsfalll changed the title TEST 【PaddlePaddle Hackathon 5】add paddle tanh_shrink op Sep 28, 2023
@Asthestarsfalll Asthestarsfalll changed the title 【PaddlePaddle Hackathon 5】add paddle tanh_shrink op 【PaddlePaddle Hackathon No.97】add paddle tanh_shrink op Sep 28, 2023
@Asthestarsfalll Asthestarsfalll changed the title 【PaddlePaddle Hackathon No.97】add paddle tanh_shrink op 【Hackathon 5th No.97】add paddle tanh_shrink op Sep 28, 2023
@Ligoml Ligoml mentioned this pull request Sep 28, 2023
Closed
@openvino-dev-samples
Copy link
Contributor

@yuxu42 Could you help to have a review on this PR, thanks

@yuxu42
Copy link
Contributor

yuxu42 commented Nov 6, 2023

@xczhai Could you please help review? Thanks!

@yuxu42 yuxu42 requested a review from azhai219 November 6, 2023 04:51
azhai219
azhai219 reviewed Nov 6, 2023
View reviewed changes
src/frontends/paddle/tests/test_models/gen_scripts/generate_tanh_shrink.py Outdated
data = np.random.uniform(-10, 20, [4, 3, 2]).astype(np.float32)
tanh_shrink("tanh_shrink_2", data)

# data = np.random.uniform(10, 20, [2, 3, 4]).astype(np.float16) // only on gpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the useless codes if unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

azhai219
azhai219 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@azhai219 azhai219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azhai219
Copy link
Contributor

azhai219 commented Nov 8, 2023

@Asthestarsfalll please rebase the PR. triger the CI again. Thanks.

@yuxu42 yuxu42 added PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event ExternalPR External contributor labels Nov 10, 2023
@azhai219 azhai219 enabled auto-merge (squash) November 13, 2023 05:39
@azhai219
Copy link
Contributor

@ceciliapeng2011 Hi Cecilia, could you help merge the PR? Thanks.

@yuxu42
Copy link
Contributor

yuxu42 commented Dec 4, 2023

@Asthestarsfalll could you rebase and fix the CI issue? Thanks!

@azhai219 azhai219 merged commit e51ba62 into openvinotoolkit:master Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceciliapeng2011 ceciliapeng2011 ceciliapeng2011 approved these changes

@azhai219 azhai219 azhai219 approved these changes

Assignees
No one assigned
Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd ExternalPR External contributor PaddlePaddle Hackathon a Intel and Baidu joint Hackathon event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Asthestarsfalll @openvino-dev-samples @yuxu42 @azhai219 @ceciliapeng2011