x-plane-plugin update for X-Plane 12 #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In X-Plane 12, pressing a key bound for any of two x-plane-plugin toggles can result in significant unexpected camera base offset shift, which can be mildly annoying.
The cause of this is X-Plane generating a rapid stream of keypress events while the key is being held down, which together with current logic of keeping camera base offset when disabling head tracking results in this problem.
An easy fix to this is only processing an initial key press and ignoring subsequent similar events until key is released. Such check is added in this pull request.
Tested in X-Plane 12 with plugin compiled against SDK 3.0.3 and SDK 4.0.0b1 on 64bit Linux. No other tests were performed. I invite @you to comment below if you can confirm that this fix works ok on any other platform or in XP11.