Skip to content

The compact output format should include a summary #1364 #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2025
Merged

The compact output format should include a summary #1364 #1369

merged 3 commits into from
Jan 27, 2025

Conversation

anaypurohit0907
Copy link
Contributor

ref: #1364

Thanks to @anderseknert for guiding me on this.

heres how the copmact reoprt looked like before :

image

heres what it will look like now :

Screenshot From 2025-01-25 22-32-40

special mention to my roomates who dont have a github, for choosing which one of the styles looked better.

@anderseknert
Copy link
Member

Awesome! Could you please update the test that verified the compact format output?

  --- FAIL: TestCompactReporterPublish (0.00s)
      reporter_test.go:171: expected +--------------+------------------------------+
          |   Location   |         Description          |
          +--------------+------------------------------+
          | a.rego:1:1   | Rego must not break the law! |
          | b.rego:22:18 | Questionable decision found  |
          +--------------+------------------------------+
          
          , got +--------------+------------------------------+
          |   Location   |         Description          |
          +--------------+------------------------------+
          | a.rego:1:1   | Rego must not break the law! |
          | b.rego:22:18 | Questionable decision found  |
          +--------------+------------------------------+
           3 files linted , 2 violations found.

When that's done, we can have this merged. Let me know if you need any help.

@anaypurohit0907
Copy link
Contributor Author

OK I'll do it and let you know.

@anderseknert anderseknert linked an issue Jan 27, 2025 that may be closed by this pull request
The compact output format should include a summary #1364
Closed
anderseknert
anderseknert approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix those (quite pedantic) style warnings post merge. Thanks for contributing to Regal! 👏

@anderseknert anderseknert merged commit 856bf50 into open-policy-agent:main Jan 27, 2025
3 of 5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 11, 2025
Merged
@renovate renovate bot mentioned this pull request Apr 4, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderseknert anderseknert anderseknert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The compact output format should include a summary
2 participants
@anaypurohit0907 @anderseknert