Only display ERRL user details callouts/strings when dumping error to console

Nick Bofferding · dcrowell77 · commit 3df3c9b61e4c · 2019-04-25T12:41:37.000-05:00
This commit fixes a bug wherein, when Hostboot dumped an error log to the console that contained user details with the same subsection ID as an ERRL string but for a different component ID, the information, which was often in binary format, would appear garbled, and would additionally terminate the BMC's SOL session due to invalid characters. The change narrows the scope of what gets emitted to just ERRL component strings/callouts. Change-Id: Ifbe83448a56955d44f0e775e123ffb95a6330b8a CQ: SW463437 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76392 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
diff --git a/src/usr/errldisplay/errldisplay.C b/src/usr/errldisplay/errldisplay.C
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2013,2017                        */
+/* Contributors Listed Below - COPYRIGHT 2013,2019                        */
 /* [+] Google Inc.                                                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
@@ -701,7 +701,7 @@ void ErrLogDisplay::msgDisplay (const errlHndl_t &i_err,
                 displayHwpf( user_data->iv_pData, user_data->iv_Size,
                              user_data->iv_header.iv_sst);
             }
-            else
+            else if(user_data->iv_header.iv_compId == ERRL_COMP_ID)
             {
                 switch ( user_data->iv_header.iv_sst )
                 {

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`/* */`
`6`	`6`	`/* OpenPOWER HostBoot Project */`
`7`	`7`	`/* */`
`8`		`-/* Contributors Listed Below - COPYRIGHT 2013,2017 */`
	`8`	`+/* Contributors Listed Below - COPYRIGHT 2013,2019 */`
`9`	`9`	`/* [+] Google Inc. */`
`10`	`10`	`/* [+] International Business Machines Corp. */`
`11`	`11`	`/* */`
`@@ -701,7 +701,7 @@ void ErrLogDisplay::msgDisplay (const errlHndl_t &i_err,`
`701`	`701`	`displayHwpf( user_data->iv_pData, user_data->iv_Size,`
`702`	`702`	`user_data->iv_header.iv_sst);`
`703`	`703`	`}`
`704`		`- else`
	`704`	`+ else if(user_data->iv_header.iv_compId == ERRL_COMP_ID)`
`705`	`705`	`{`
`706`	`706`	`switch ( user_data->iv_header.iv_sst )`
`707`	`707`	`{`