Skip to content

Commit c368037

Browse files
aamarincrgeddes
authored andcommitted
Update phy_pharams structure, tests, and exp attrs
Change-Id: Ie84463e9497bf53d8cd13b14526be93d9de95506 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72070 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72086 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
1 parent 5618f2f commit c368037

File tree

3 files changed

+919
-553
lines changed

3 files changed

+919
-553
lines changed

src/import/chips/ocmb/explorer/procedures/hwp/memory/lib/exp_draminit_utils.C

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,14 @@ fapi2::ReturnCode setup_phy_params(const fapi2::Target<fapi2::TARGET_TYPE_OCMB_C
7373
for (const auto l_port : mss::find_targets<fapi2::TARGET_TYPE_MEM_PORT>(i_target))
7474
{
7575
fapi2::ReturnCode l_rc;
76-
77-
// Create an object
78-
auto l_set_phy_params = phy_params(l_port, l_rc);
79-
FAPI_TRY(l_rc, "Unable to set parameters for target %s", mss::c_str(i_target));
76+
const phy_params l_set_phy_params(l_port, l_rc);
77+
FAPI_TRY(l_rc, "Unable to instantiate phy_params for target %s", mss::c_str(i_target));
8078

8179
// Set the params by fetching them from the attributes
82-
FAPI_TRY(l_set_phy_params.setup_DimmType(l_port, o_phy_params));
83-
FAPI_TRY(l_set_phy_params.setup_CsPresent(l_port, o_phy_params));
84-
FAPI_TRY(l_set_phy_params.setup_DramDataWidth(l_port, o_phy_params));
85-
FAPI_TRY(l_set_phy_params.setup_Height3DS(l_port, o_phy_params));
80+
FAPI_TRY(l_set_phy_params.setup_DimmType(o_phy_params));
81+
FAPI_TRY(l_set_phy_params.setup_CsPresent(o_phy_params));
82+
FAPI_TRY(l_set_phy_params.setup_DramDataWidth(o_phy_params));
83+
FAPI_TRY(l_set_phy_params.setup_Height3DS(o_phy_params));
8684
FAPI_TRY(l_set_phy_params.set_ActiveDBYTE(o_phy_params));
8785
FAPI_TRY(l_set_phy_params.set_ActiveNibble(o_phy_params));
8886
FAPI_TRY(l_set_phy_params.set_AddrMirror(o_phy_params));

0 commit comments

Comments
 (0)