[Feature] Config new type #2390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## new_config #2390 +/- ##
===========================================
Coverage 82.02% 82.03%
===========================================
Files 233 233
Lines 13643 13645 +2
Branches 2320 2321 +1
===========================================
+ Hits 11191 11194 +3
+ Misses 1916 1914 -2
- Partials 536 537 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
When I attempt to train using the config file Traceback (most recent call last):
File "/mnt/workspace/lupeng/new_config/mmengine/mmengine/registry/build_functions.py", line 122, in build_from_cfg
obj = obj_cls(**args) # type: ignore
File "/mnt/workspace/lupeng/new_config/mmpose/mmpose/models/pose_estimators/topdown.py", line 47, in __init__
super().__init__(
File "/mnt/workspace/lupeng/new_config/mmpose/mmpose/models/pose_estimators/base.py", line 47, in __init__
self.backbone = MODELS.build(backbone)
File "/mnt/workspace/lupeng/new_config/mmengine/mmengine/registry/registry.py", line 554, in build
return self.build_func(cfg, *args, **kwargs, registry=self)
File "/mnt/workspace/lupeng/new_config/mmengine/mmengine/registry/build_functions.py", line 250, in build_model_from_cfg
return build_from_cfg(cfg, registry, default_args)
File "/mnt/workspace/lupeng/new_config/mmengine/mmengine/registry/build_functions.py", line 144, in build_from_cfg
raise type(e)(
TypeError: class `CSPNeXt` in mmdet/models/backbones/cspnext.py: The key argument of `Registry.get` must be a str, got <class 'type'> |
Ben-Louis
approved these changes
May 24, 2023
Tau-J
pushed a commit
that referenced
this pull request
Jun 1, 2023
Tau-J
pushed a commit
to Tau-J/mmpose
that referenced
this pull request
Jun 16, 2023
Tau-J
pushed a commit
to Tau-J/mmpose
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modification
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: