Skip to content

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

The motivation to upgrade some versions of pre-commit hooks to latest is that importlib-metadata v5.0.0 which removed deprecated endpoint breaks the flake8

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 84.46% // Head: 84.46% // No change to project coverage 👍

Coverage data is based on head (52473c2) compared to base (dd3c494).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   84.46%   84.46%           
=======================================
  Files         236      236           
  Lines       20039    20039           
  Branches     3603     3603           
=======================================
  Hits        16925    16925           
  Misses       2233     2233           
  Partials      881      881           
Flag Coverage Δ
unittests 84.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ben-Louis Ben-Louis requested a review from ly015 October 8, 2022 06:26
@ly015 ly015 merged commit 2b0cd7a into open-mmlab:master Oct 8, 2022
@Ben-Louis Ben-Louis deleted the upgrade-pre-commit-hooks branch October 9, 2022 08:10
evendrow pushed a commit to evendrow/mmpose that referenced this pull request Dec 22, 2022
* Upgrade the versions of pre-commit-hooks

* fix circle-ci

* fix circle-ci albumentations dependency

* remove annotatiion dependency
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 5, 2023
* Upgrade the versions of pre-commit-hooks

* fix circle-ci

* fix circle-ci albumentations dependency

* remove annotatiion dependency
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Upgrade the versions of pre-commit-hooks

* fix circle-ci

* fix circle-ci albumentations dependency

* remove annotatiion dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants