Skip to content

[Refactor] Refactor detection dataset metainfo to lowercase and update detection metric logics #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Mar 14, 2023
Merged

[Refactor] Refactor detection dataset metainfo to lowercase and update detection metric logics #98

merged 33 commits into from
Mar 14, 2023

Conversation

BIGWangYuDong
Copy link
Collaborator

Motivation

Sync with open-mmlab/mmdetection#9469

Modification

Refactor detection dataset metainfo to lowercase

@CLAassistant
Copy link

CLAassistant commented Feb 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@BIGWangYuDong BIGWangYuDong mentioned this pull request Feb 20, 2023
Merged
@BIGWangYuDong BIGWangYuDong mentioned this pull request Feb 21, 2023
Open
RangiLyu
RangiLyu reviewed Feb 23, 2023
View reviewed changes
@BIGWangYuDong
Copy link
Collaborator Author

image
Supporting saving coco summarize information

RangiLyu
RangiLyu reviewed Feb 27, 2023
View reviewed changes
@BIGWangYuDong BIGWangYuDong requested review from zhouzaida and RangiLyu and removed request for HAOCHENYE February 28, 2023 02:12
RangiLyu
RangiLyu reviewed Feb 28, 2023
View reviewed changes
RangiLyu
RangiLyu reviewed Feb 28, 2023
View reviewed changes
RangiLyu
RangiLyu reviewed Feb 28, 2023
View reviewed changes
RangiLyu
RangiLyu reviewed Feb 28, 2023
View reviewed changes
@BIGWangYuDong
Copy link
Collaborator Author

Kindly ping @C1rN09 to have a look at the logic of geting self.classes

C1rN09
C1rN09 reviewed Mar 1, 2023
View reviewed changes
@BIGWangYuDong BIGWangYuDong changed the title [Refactor] Refactor detection dataset metainfo to lowercase [Refactor] Refactor detection dataset metainfo to lowercase and update detection metric logics Mar 1, 2023
@BIGWangYuDong
Copy link
Collaborator Author

Done

@BIGWangYuDong BIGWangYuDong requested a review from C1rN09 March 1, 2023 12:05
@BIGWangYuDong
Copy link
Collaborator Author

After #102, We can print table and logs in mmeval, and can update the logic in mmdet.

C1rN09
C1rN09 reviewed Mar 9, 2023
View reviewed changes
BIGWangYuDong and others added 2 commits March 13, 2023 11:58
@BIGWangYuDong @C1rN09
Update mmeval/metrics/coco_detection.py
6714659 
Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
@BIGWangYuDong
fix comments
b7c6f9e
@BIGWangYuDong BIGWangYuDong requested a review from C1rN09 March 13, 2023 04:04
BIGWangYuDong
BIGWangYuDong commented Mar 14, 2023
View reviewed changes
zhouzaida
zhouzaida reviewed Mar 14, 2023
View reviewed changes
zhouzaida
zhouzaida reviewed Mar 14, 2023
View reviewed changes
zhouzaida
zhouzaida reviewed Mar 14, 2023
View reviewed changes
BIGWangYuDong and others added 3 commits March 14, 2023 19:00
@BIGWangYuDong @zhouzaida
Update mmeval/metrics/coco_detection.py
a331ea2 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@BIGWangYuDong @zhouzaida
Update mmeval/metrics/oid_map.py
6ff2526 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@BIGWangYuDong @zhouzaida
Update mmeval/metrics/voc_map.py
64bfc40 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida merged commit 976f399 into open-mmlab:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangiLyu RangiLyu RangiLyu approved these changes

@zhouzaida zhouzaida zhouzaida approved these changes

@C1rN09 C1rN09 Awaiting requested review from C1rN09 C1rN09 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BIGWangYuDong @CLAassistant @RangiLyu @zhouzaida @C1rN09