Skip to content

Conversation

xuan07472
Copy link
Contributor

@xuan07472 xuan07472 commented Jan 9, 2023

Motivation

Add MattingSAD of MMEditing to MMEval and complete the adaptation.

Modification

Add MattingSAD of MMEditing to MMEval
The PR link using mmeval.SAD in mmediting:open-mmlab/mmagic#1592 (comment)

Modify the details.

Co-authored-by: yancong <32220263+ice-tong@users.noreply.github.com>
@xuan07472 xuan07472 changed the title [CodeCamp #1535] Add MattingSAD [CodeCamp #1535] Add SAD Jan 9, 2023
Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 comments

xuan07472 and others added 2 commits January 10, 2023 16:20
Optimize details

Co-authored-by: yancong <32220263+ice-tong@users.noreply.github.com>
@LeoXing1996
Copy link
Collaborator

LGTM 🚀

Co-authored-by: LeoXing1996 <xingzn1996@hotmail.com>
@ice-tong ice-tong requested a review from zhouzaida January 10, 2023 12:49
@ice-tong
Copy link
Collaborator

Please @zhouzaida have a look~

@zhouzaida zhouzaida merged commit eb92639 into open-mmlab:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants