[Fix] Revert #1548 #1556
Merged
[Fix] Revert #1548 #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1556 +/- ##
==========================================
- Coverage 50.19% 50.16% -0.03%
==========================================
Files 223 223
Lines 19113 19104 -9
Branches 3136 3134 -2
==========================================
- Hits 9594 9584 -10
- Misses 8940 8941 +1
Partials 579 579
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ZwwWayne
approved these changes
Jun 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Revert #1548 as it didn't fix any bugs.
Modification
Remove
DepthInstance3DBoxes.overlaps.BC-breaking (Optional)
Yes but it is a bug fix only in
devbranch.