Skip to content

[Enhance] Support with_velocity=False in CenterPoint and NuScenesDataset #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2022
Merged

[Enhance] Support with_velocity=False in CenterPoint and NuScenesDataset #1469

merged 6 commits into from
Jun 27, 2022

Conversation

YuanxianH
Copy link
Contributor

Motivation

Fix some bugs of CenterPoint and NuScenesDataset when the velocity head in the CenterHead's common_heads is ignored.

Modification

  • Simply add some conditional statements to support CenterPoint without the vel common head.
  • Add a config file to test the no-velocity version of CenterPoint

Tai-Wang
Tai-Wang reviewed May 10, 2022
View reviewed changes
Tai-Wang
Tai-Wang reviewed May 10, 2022
View reviewed changes
Tai-Wang
Tai-Wang reviewed May 18, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1469 (f027e50) into dev (4422eaa) will decrease coverage by 0.24%.
The diff coverage is 34.48%.

@@            Coverage Diff             @@
##              dev    #1469      +/-   ##
==========================================
- Coverage   50.39%   50.15%   -0.25%     
==========================================
  Files         221      223       +2     
  Lines       18927    19124     +197     
  Branches     3118     3141      +23     
==========================================
+ Hits         9538     9591      +53     
- Misses       8811     8953     +142     
- Partials      578      580       +2
Flag Coverage Δ
unittests 50.15% <34.48%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/dense_heads/centerpoint_head.py 44.05% <9.09%> (-0.69%) ⬇️
mmdet3d/datasets/nuscenes_dataset.py 40.35% <20.00%> (-0.36%) ⬇️
mmdet3d/datasets/pipelines/dbsampler.py 74.07% <20.00%> (-1.73%) ⬇️
mmdet3d/models/detectors/centerpoint.py 17.44% <66.66%> (+1.77%) ⬆️
mmdet3d/datasets/pipelines/loading.py 90.17% <100.00%> (+0.10%) ⬆️
mmdet3d/models/middle_encoders/sparse_encoder.py 38.99% <0.00%> (-35.20%) ⬇️
mmdet3d/datasets/builder.py 42.42% <0.00%> (-0.91%) ⬇️
mmdet3d/core/post_processing/box3d_nms.py 27.89% <0.00%> (-0.88%) ⬇️
...3d/models/roi_heads/bbox_heads/parta2_bbox_head.py 67.78% <0.00%> (-0.44%) ⬇️
mmdet3d/datasets/custom_3d_seg.py 67.29% <0.00%> (-0.43%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4422eaa...f027e50. Read the comment docs.

@Tai-Wang Tai-Wang changed the title fixed some bugs of CenterPoint and NuScenesDataset when velocity is ignored [Enhance] Support with_velocity=False in CenterPoint and NuScenesDataset Jun 24, 2022
@ZwwWayne ZwwWayne merged commit 23e858b into open-mmlab:dev Jun 27, 2022
tyomj pushed a commit to tyomj/mmdetection3d that referenced this pull request Apr 26, 2023
@akozlov-outrider
Returning dbsampler arg from PR open-mmlab#1469
7766287
tyomj pushed a commit to tyomj/mmdetection3d that referenced this pull request May 10, 2023
@akozlov-outrider
Returning dbsampler arg from PR open-mmlab#1469
e4b9a55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tai-Wang Tai-Wang Tai-Wang approved these changes

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanxianH @Tai-Wang @ZwwWayne