Skip to content

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Jul 16, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

https://readthedocs.org/projects/mmcv/builds/17455215/

Failed to build docs due to breaking changes of markdown3.4. More details at ryanfox/sphinx-markdown-tables#36.

Modification

Fix the markdown version.

BC-breaking (Optional)

No

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@zhouzaida zhouzaida marked this pull request as draft July 16, 2022 03:31
@zhouzaida zhouzaida changed the title [Docs] Fix sphinx markdown tables version [Docs] Fix markdown version Jul 17, 2022
@zhouzaida zhouzaida marked this pull request as ready for review July 17, 2022 10:54
@zhouzaida zhouzaida merged commit b58c84c into open-mmlab:master Jul 17, 2022
@zhouzaida zhouzaida deleted the fix-sphinx-markdown-tables-version branch July 17, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants