Skip to content

[Update] Update configurations #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

[Update] Update configurations #1704

merged 1 commit into from
Nov 21, 2024

Conversation

MaiziXiao
Copy link
Contributor

  1. Add error handler for Openai SDK (i.e. for models like step-2)
  2. Update LCB configurations, add fallback_role in case of API models
  3. Add some base models configuration
  4. Update TurboMindModelwithChatTemplate, making sure the max_out_len has higher priority than max_new_tokens in gen_config

@MaiziXiao MaiziXiao requested a review from tonysy November 20, 2024 08:38
tonysy
tonysy approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaiziXiao MaiziXiao merged commit 500fb10 into open-compass:main Nov 21, 2024
8 checks passed
stephen-nju pushed a commit to stephen-nju/opencompass that referenced this pull request May 14, 2025
@MaiziXiao
[Update] Update configurations (open-compass#1704)
54ff648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonysy tonysy tonysy approved these changes

Assignees

@MaiziXiao MaiziXiao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaiziXiao @tonysy