Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: onsi/ginkgo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.22.0
Choose a base ref
...
head repository: onsi/ginkgo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.22.1
Choose a head ref
  • 7 commits
  • 22 files changed
  • 4 contributors

Commits on Dec 6, 2024

  1. Add meta-test

    This test fails on this commit, which shows that it properly detects
    that
    
        outline/_testdata/position_test.go.csv
    
    can not be correctly parsed due to having too many fields.
    
    This test passes on the HEAD of this branch.
    belden authored and onsi committed Dec 6, 2024
    Configuration menu
    Copy the full SHA
    43dad69 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2024

  1. Add test case for proper csv escaping

    I generated the _test.go.{csv,json} files by using a version of ginkgo
    built from the next commit.
    
    If tests are run on this sha, they are expected to fail; the next
    commit fixes them.
    belden authored and onsi committed Dec 19, 2024
    Configuration menu
    Copy the full SHA
    96a80fc View commit details
    Browse the repository at this point in the history
  2. Properly encode CSV rows

    Ensure CSV formatting properly encodes various edge-case values.
    
    We lean on `encoding/csv` from the go stdlib to do the work for
    us. In order to mix writing indentation with writing csv rows, we must
    csvWriter.Flush() after every csvWriter.Write(row).
    belden authored and onsi committed Dec 19, 2024
    Configuration menu
    Copy the full SHA
    c09df39 View commit details
    Browse the repository at this point in the history
  3. Update tests

    The trailing `""` to wrap empty labels was a CSV error. This commit
    simply updates the test files to be properly encoded. It is a result
    of running the updated `ginkgo` binary from the previous commit across
    all of the _testdata files.
    
    ----
    
    There was prior art within `outline/outline.go` which tried to
    properly enclose a comma-separated list of labels within double
    quotes. This resulted in CSV output with trailing `""` characters for
    tests that have no labels.
    
    A trailing `""` is incorrect for CSV formatting.
    
    There are two special characters within CSV formatting:
    
        "  0x22   DOUBLE QUOTE
        ,  0x2c   COMMA
    
    The mechanism to embed the field-separator 0x2c within a string is to
    enclose it within quotation marks. The mechanism to embed the
    quotation mark within a string is to use two quotation marks. i.e.
    the following string:
    
        // go code
        foo := "The dog looked at me and said, \"Bark, bark!\""
    
    should be represented in CSV as
    
        Punchline,Laughs
        "The dog looked at me and said, ""Bark, bark!""",17
    
    just as it would be represnted in JSON as
    
        {
            "punchline": "The dog looked at me and said, \"Bark, bark!\"",
            "laughs": 17
        }
    belden authored and onsi committed Dec 19, 2024
    Configuration menu
    Copy the full SHA
    aab3da6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c88c634 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2024

  1. remove golang.org/x/net/context in favour of stdlib context

    and minor dependency updates
    
    Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
    tariq1890 authored and onsi committed Dec 20, 2024
    Configuration menu
    Copy the full SHA
    4df44bf View commit details
    Browse the repository at this point in the history
  2. v2.22.1

    onsi committed Dec 20, 2024
    Configuration menu
    Copy the full SHA
    a0190b7 View commit details
    Browse the repository at this point in the history
Loading