Skip to content

Enable more compiler warnings #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2024
Merged

Enable more compiler warnings #6383

merged 3 commits into from
Sep 26, 2024

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 22, 2024 •
edited
Loading

Description

Clean up some build warnings.

Motivation and Context

For better code.

@cyyever cyyever requested a review from a team as a code owner September 22, 2024 03:56
@cyyever cyyever marked this pull request as draft September 22, 2024 03:56
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (d14634e) to head (e3d8254).
Report is 339 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6383   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files         507      507           
  Lines       31406    31406           
  Branches     4690     4690           
=======================================
  Hits        17975    17975           
- Misses      12575    12576    +1     
+ Partials      856      855    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added the run release CIs Use this label to trigger release tests in CI label Sep 22, 2024
@cyyever
Enable more warnings
d4b7bea 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever
Fix clang-tidy warnings
d367c43 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever cyyever marked this pull request as ready for review September 25, 2024 02:02
@cyyever
Simplify Werror
e3d8254 
Signed-off-by: cyy <cyyever@outlook.com>
@justinchuby justinchuby added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Sep 25, 2024
@cyyever cyyever changed the title Enable more warnings Enable more compiler warnings Sep 25, 2024
@justinchuby justinchuby added this pull request to the merge queue Sep 26, 2024
Merged via the queue into onnx:main with commit 5f95155 Sep 26, 2024
74 checks passed
@cyyever cyyever deleted the warning branch September 27, 2024 00:43
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@cyyever @linshokaku
Enable more compiler warnings (onnx#6383)
211dd43 
### Description
<!-- - Describe your changes. -->
Clean up some build warnings.
### Motivation and Context
For better code.
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

---------

Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
@ramkrishna2910 ramkrishna2910 added the topic: build Issues related to ONNX builds and packages label May 12, 2025
@botantony botantony mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyyever @justinchuby @ramkrishna2910