Use CMake python module #6381
Merged
Use CMake python module #6381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b1f256 to
c501e92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6381 +/- ##
=======================================
Coverage 57.23% 57.23%
=======================================
Files 507 507
Lines 31406 31406
Branches 4690 4690
=======================================
Hits 17975 17975
- Misses 12575 12576 +1
+ Partials 856 855 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: cyy <cyyever@outlook.com>
c501e92 to
80e4961
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
### Description <!-- - Describe your changes. --> Revert the python finding logic introduced by #6381 due to unable to handle Conda builds. However, the Python executable detection was improved. In addition, some Windows warnings were re-enabled, and the hidden visibility of onnx_cpp2py_export was fixed. ### Motivation and Context For better code. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: cyy <cyyever@outlook.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Motivation and Context Remove usage of deprecated module. Signed-off-by: cyy <cyyever@outlook.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description <!-- - Describe your changes. --> Revert the python finding logic introduced by onnx#6381 due to unable to handle Conda builds. However, the Python executable detection was improved. In addition, some Windows warnings were re-enabled, and the hidden visibility of onnx_cpp2py_export was fixed. ### Motivation and Context For better code. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: cyy <cyyever@outlook.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove usage of deprecated module.