-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Python 3.13: builds successful for all os #6370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6370 +/- ##
==========================================
+ Coverage 57.38% 57.39% +0.01%
==========================================
Files 507 507
Lines 31511 31523 +12
Branches 3546 3548 +2
==========================================
+ Hits 18082 18094 +12
Misses 12581 12581
Partials 848 848 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
How we treat our tolerance issues? https://github.com/onnx/onnx/actions/runs/11791162070/job/32842797011
|
Skip for now? Or is there a way to change the tolerance? 1e-7 for dft seems to be a little strict? |
I wonder what exactly does or is the point of the test? I mean only NumPy 2.1.0 supports python 3.13? So installing something that is smaller than numpy < 2 makes little sense at first view? |
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Right. It’s only for compatibility checking. When we drop more and more python versions we can drop the unsupported numpy versions as well. |
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Description
Python 3.13: builds successful for all os, some deps (e.g google-re2) are not ready for 3.13 yet
Therefore the some tests are disable for python 3.13
Motivation and Context