Skip to content

Python 3.13: builds successful for all os #6370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Nov 14, 2024
Merged

Python 3.13: builds successful for all os #6370

merged 55 commits into from
Nov 14, 2024

Conversation

andife
Copy link
Member

@andife andife commented Sep 16, 2024

Description

Python 3.13: builds successful for all os, some deps (e.g google-re2) are not ready for 3.13 yet
Therefore the some tests are disable for python 3.13

Motivation and Context

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife requested a review from a team as a code owner September 16, 2024 17:27
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (e22a46f) to head (9a5a61c).
Report is 254 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6370      +/-   ##
==========================================
+ Coverage   57.38%   57.39%   +0.01%     
==========================================
  Files         507      507              
  Lines       31511    31523      +12     
  Branches     3546     3548       +2     
==========================================
+ Hits        18082    18094      +12     
  Misses      12581    12581              
  Partials      848      848              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife changed the title WIP Python 3.13: start ubuntu WIP Python 3.13-dev: build successful, some deps are not ready for 3.13-dev yet Sep 17, 2024
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife changed the title WIP Python 3.13-dev: build successful, some deps are not ready for 3.13-dev yet WIP Python 3.13-dev: builds successful for all os, some deps (e.g google-re2) are not ready for 3.13 yet Sep 19, 2024
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife changed the title WIP Python 3.13-dev: builds successful for all os, some deps (e.g google-re2) are not ready for 3.13 yet WIP Python 3.13: builds successful for all os, some deps (e.g google-re2) are not ready for 3.13 yet Oct 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife
Copy link
Member Author

andife commented Nov 12, 2024

How we treat our tolerance issues?

https://github.com/onnx/onnx/actions/runs/11791162070/job/32842797011


Mismatched elements: 20 / 200 (10%)
Max absolute difference: 1.859665e-05
Max relative difference: 5.5504855e+09
 x: array([[[[ 4.500000e+01, -1.335144e-05],
         [ 4.600000e+01, -1.478195e-05],
         [ 4.[700](https://github.com/onnx/onnx/actions/runs/11791162070/job/32842797011#step:21:701)000e+01, -1.487732e-05],...
 y: array([[[[ 4.500000e+01,  0.000000e+00],
         [ 4.600000e+01,  0.000000e+00],
         [ 4.700000e+01,  0.000000e+00],...
FAILED onnx/test/test_backend_onnxruntime.py::OnnxBackendNodeModelTest::test_dft_opset19_cpu - AssertionError: 
Not equal to tolerance rtol=0.001, atol=1e-07

@justinchuby

@justinchuby
Copy link
Member

Skip for now? Or is there a way to change the tolerance? 1e-7 for dft seems to be a little strict?

@andife
Copy link
Member Author

andife commented Nov 13, 2024

Skip for now? Or is there a way to change the tolerance? 1e-7 for dft seems to be a little strict?

I wonder what exactly does or is the point of the test? I mean only NumPy 2.1.0 supports python 3.13? So installing something that is smaller than numpy < 2 makes little sense at first view?

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@justinchuby
Copy link
Member

Skip for now? Or is there a way to change the tolerance? 1e-7 for dft seems to be a little strict?

I wonder what exactly does or is the point of the test? I mean only NumPy 2.1.0 supports python 3.13? So installing something that is smaller than numpy < 2 makes little sense at first view?

Right. It’s only for compatibility checking. When we drop more and more python versions we can drop the unsupported numpy versions as well.

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

andife and others added 3 commits November 13, 2024 20:16
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife and others added 2 commits November 14, 2024 01:40
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit f5be0c2 Nov 14, 2024
39 checks passed
@andife andife deleted the andife-patch-2 branch November 14, 2024 12:12
@andife andife mentioned this pull request Feb 18, 2025
@alanwilter alanwilter mentioned this pull request Mar 11, 2025
@ramkrishna2910 ramkrishna2910 added the topic: build Issues related to ONNX builds and packages label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants