Skip to content

Update Protobuf to latest version (Win) #6362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2024
Merged

Update Protobuf to latest version (Win) #6362

merged 2 commits into from
Sep 12, 2024
+1 −4

Conversation

liqunfu
Copy link
Collaborator

@liqunfu liqunfu commented Sep 11, 2024

Description

Motivation and Context

@liqunfu
Test with the latest protobuf because protobuf/issues/18045 is fixed
726f5d6 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu requested a review from a team as a code owner September 11, 2024 16:27
@liqunfu liqunfu added the run release CIs Use this label to trigger release tests in CI label Sep 11, 2024
@liqunfu liqunfu closed this Sep 11, 2024
@liqunfu liqunfu reopened this Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (444e894) to head (8d0bbe5).
Report is 349 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6362   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files         507      507           
  Lines       31406    31406           
  Branches     4690     4690           
=======================================
  Hits        17975    17975           
  Misses      12576    12576           
  Partials      855      855

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andife andife changed the title Test with the latest protobuf because protobuf/issues/18045 is fixed Update Protobuf to latest version (Win) Sep 12, 2024
@andife andife added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 0d3e99b Sep 12, 2024
74 checks passed
@andife andife deleted the liqun/test_latest_protobuf branch September 12, 2024 08:49
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@liqunfu @andife @linshokaku
Update Protobuf to latest version (Win) (onnx#6362)
fcfaf9c 
### Description
<!-- - Describe your changes. -->

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->

Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Co-authored-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
@ramkrishna2910 ramkrishna2910 added the topic: build Issues related to ONNX builds and packages label May 12, 2025
@botantony botantony mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liqunfu @justinchuby @ramkrishna2910 @andife