Extend printer and parser to support invalid identifiers #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
=======================================
Coverage 57.23% 57.23%
=======================================
Files 507 507
Lines 31407 31407
Branches 4690 4690
=======================================
Hits 17977 17977
Misses 12575 12575
Partials 855 855 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Sep 4, 2024
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Done, thanks. |
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
Many onnx models used in practice use tensor names that are not valid C identifiers (as required by the ONNX standard). This PR extends the printer and parser to support such identifiers. (It may be useful to relax the ONNX standard's requirements in this regard, but that's a separate issue, requiring some community discussion.) --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many onnx models used in practice use tensor names that are not valid C identifiers (as required by the ONNX standard). This PR extends the printer and parser to support such identifiers.
(It may be useful to relax the ONNX standard's requirements in this regard, but that's a separate issue, requiring some community discussion.)